[Fix] Add missing stubs from cpu fp8 attention changes#41387
[Fix] Add missing stubs from cpu fp8 attention changes#41387bigPYJ1151 merged 9 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Li, Tianmu <tianmu.li@intel.com>
|
Hi @tianmu-li, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
There was a problem hiding this comment.
Code Review
This pull request adds FP8 stub constructors and type tags to various CPU architecture headers (ARM, Scalar, VSX, and VXE) to facilitate cross-platform compilation of shared templates. Feedback highlights that the stubs in the Scalar, VSX, and VXE files incorrectly attempt to use a Base alias that is not defined, which will cause compilation errors; these should be updated to initialize the reg member directly.
Signed-off-by: Li, Tianmu <tianmu.li@intel.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces FP8 stubs and tag structures across several CPU architecture-specific headers, including ARM, Scalar, VSX (PowerPC), and VXE (s390x). These additions provide the necessary constructor overloads to allow the load_b_pair_vec template to compile on all platforms, even though FP8 KV cache functionality is currently restricted to x86 architectures. I have no feedback to provide as there were no review comments to evaluate.
|
@bigPYJ1151 Appreciate it if you could take a look. This is to address compilation issues using clang (found on m1 smoke test) and add some missing stubs. |
|
Tested on macOS arm64 (Apple Silicon, Apple Clang 21) and the build now succeeds:
Filed issue #41437 reproducing the same error before noticing this PR was already in flight — closing the loop here so the cross-reference exists. Thanks for the quick fix! |
|
Confirmed this fixes the macOS arm64 source build failure I hit on main. Environment:
Before this patch, After applying the |
…stubs Signed-off-by: Li, Tianmu <tianmu.li@intel.com>
Head branch was pushed to by a user without write access
|
@bigPYJ1151 Appreciate it if you could help merge this. I had to push a commit to resolve a merge conflict, which disabled auto-merge. |
…41387) Signed-off-by: Li, Tianmu <tianmu.li@intel.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com>
…41387) Signed-off-by: Li, Tianmu <tianmu.li@intel.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com> Signed-off-by: Mehdi Ghanimifard <mehdi.ghanimifard@amd.com>
…41387) Signed-off-by: Li, Tianmu <tianmu.li@intel.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com> Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
…41387) Signed-off-by: Li, Tianmu <tianmu.li@intel.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com> Signed-off-by: Libin Tang <libin.tang@intel.com>
Purpose
#39445 is missing some stubs for fp8 attention, which cause compilation errors when using clang (see https://github.com/tianmu-li/vllm/actions/runs/25149522905/job/73716695058#logs). This PR adds them.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.