Skip to content

[Bugfix] Fix double reduce in flashinfer_nvlink_two_sided and flashinfer_nvlink_one_sided backends #41382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgoin merged 3 commits into from
May 12, 2026
Merged

[Bugfix] Fix double reduce in flashinfer_nvlink_two_sided and flashinfer_nvlink_one_sided backends #41382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30ad820
Change 'output_is_reduced' to return True in flashinfer_nvlink_two_si…
amitz-nv Apr 30, 2026
0d99149
Merge branch 'main' into fix-accuracy-fi-nvlink-one-two-sided
mergify[bot] May 7, 2026
039c635
Merge branch 'main' into fix-accuracy-fi-nvlink-one-two-sided
robertgshaw2-redhat May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/model_executor/layers/fused_moe/prepare_finalize/flashinfer_nvlink_one_sided.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def num_dispatchers(self) -> int:
return self.num_dispatchers_

def output_is_reduced(self) -> bool:
return False
return True

def topk_indices_dtype(self) -> torch.dtype | None:
return torch.int32
Expand Down
2 changes: 1 addition & 1 deletion vllm/model_executor/layers/fused_moe/prepare_finalize/flashinfer_nvlink_two_sided.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def num_dispatchers(self) -> int:
return self.num_dispatchers_

def output_is_reduced(self) -> bool:
return False
return True

def _apply_router_weight_on_input(
self,
Expand Down
Loading