[Bugfix] Workaround for DeepSeek V4 MTP=1 hang issue#41168
Closed
wzhao18 wants to merge 1 commit intovllm-project:mainfrom
Closed
[Bugfix] Workaround for DeepSeek V4 MTP=1 hang issue#41168wzhao18 wants to merge 1 commit intovllm-project:mainfrom
wzhao18 wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the DeepseekV4IndexerMetadataBuilder class, which inherits from DeepseekV32IndexerMetadataBuilder and defines natively_supported_next_n_fp4. It also updates the indexer to return this new builder class through the get_builder_cls static method. I have no feedback to provide as there were no review comments to evaluate.
Contributor
Author
|
Should be fixed by: #41189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently running DeepSeek V4 MTP=1 will hang. Reproduction:
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.