Skip to content

[CI] De-flake test_chat_completion_n_parameter_non_streaming #41147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 2 commits into from
Apr 29, 2026
Merged

[CI] De-flake test_chat_completion_n_parameter_non_streaming #41147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd2b037
[CI] De-flake test_chat_completion_n_parameter_non_streaming
haosdent Apr 28, 2026
fc8cd6f
Merge branch 'main' into ci-c77b5fdf
chaunceyjiang Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/entrypoints/openai/chat_completion/test_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,9 +845,10 @@ async def test_chat_completion_n_parameter_non_streaming(
chat_completion = await client.chat.completions.create(
model=model_name,
messages=messages,
max_completion_tokens=20,
temperature=0.7,
max_completion_tokens=50,
temperature=1.0,
n=3,
seed=42,
stream=False,
)

Expand All @@ -859,7 +860,6 @@ async def test_chat_completion_n_parameter_non_streaming(
assert choice.message.content is not None
assert len(choice.message.content) > 0

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The comment was removed, but it provided useful context for the assertion that follows. If the assertion is intended to verify diversity, the comment should be kept or updated to reflect the new deterministic approach.

Suggested change
# Verify all responses are different (deterministic with seed=42)

# Verify all responses are different (highly likely with temperature > 0)
contents = [choice.message.content for choice in chat_completion.choices]
assert len(set(contents)) > 1, "Expected different responses with n=3"

Expand Down
Loading