Skip to content

[Examples][last/6] Resettle examples.#41084

Merged
vllm-bot merged 14 commits intovllm-project:mainfrom
noooop:resettle_examples_applications
May 8, 2026
Merged

[Examples][last/6] Resettle examples.#41084
vllm-bot merged 14 commits intovllm-project:mainfrom
noooop:resettle_examples_applications

Conversation

@noooop
Copy link
Copy Markdown
Collaborator

@noooop noooop commented Apr 28, 2026

Purpose

Resettle all examples.

Fix #29362

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop force-pushed the resettle_examples_applications branch from e504533 to 7075880 Compare April 28, 2026 03:13
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 28, 2026

Documentation preview: https://vllm--41084.org.readthedocs.build/en/41084/

@mergify mergify Bot added documentation Improvements or additions to documentation llama Related to Llama models labels Apr 28, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the examples directory by moving scripts and Helm charts from online_serving into more descriptive subdirectories such as applications/chatbot, applications/rag, and deployment. Corresponding documentation links have been updated to reflect these new paths. A typo was identified in the retrieval-augmented generation documentation where a directory name was duplicated in a link's display text.

Comment thread docs/deployment/frameworks/retrieval_augmented_generation.md Outdated
noooop and others added 3 commits April 28, 2026 11:24
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop force-pushed the resettle_examples_applications branch from 9d40add to 8ac6a4b Compare April 28, 2026 09:42
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify mergify Bot added the ci/build label Apr 28, 2026
noooop and others added 3 commits April 28, 2026 17:49
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify mergify Bot added the kv-connector label May 6, 2026
Comment thread .buildkite/scripts/hardware_ci/run-tpu-v1-test.sh
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop marked this pull request as ready for review May 6, 2026 09:23
@noooop noooop requested review from 22quinn and jeejeelee as code owners May 6, 2026 09:23
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 6, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

noooop added 3 commits May 6, 2026 17:31
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop requested a review from DarkLight1337 May 7, 2026 02:50
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 7, 2026 08:27
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2026
@vllm-bot vllm-bot merged commit 1d694e7 into vllm-project:main May 8, 2026
145 of 152 checks passed
@noooop noooop deleted the resettle_examples_applications branch May 8, 2026 06:29
libinta pushed a commit to libinta/vllm that referenced this pull request May 8, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Libin Tang <libin.tang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation kv-connector llama Related to Llama models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Resettle examples.

4 participants