[ROCm][CI] Move ROCm AITER quantization tests by AndreasKaratzas · Pull Request #40938 · vllm-project/vllm

AndreasKaratzas · 2026-04-26T21:32:20Z

move ROCm AITER quantization tests into tests/kernels/quantization
move MLA FP8 support detection coverage into tests/kernels/attention
run the MLA support test in both the MI300 and MI355 Kernels MLA jobs
remove the standalone ROCm AITER Ops Test after assigning every test to a maintained kernel suite

The standalone tests/rocm/aiter job duplicated ownership already provided by the kernel test suites. This update rebases the cleanup onto current main, including the AITER hipBLASLt and quantization-schema tests added after the original PR, so removing the standalone job does not leave any tests uncollected. The quantization groups now also depend on vllm/kernels/aiter_ops.py, ensuring changes to the tested RMSNorm registration opt the suite into AMD CI. The MLA support fixture restores its capability cache after every test to avoid leaking fake-module state into adjacent tests.

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

gemini-code-assist

Code Review

This pull request introduces a new test suite for ROCm AITER grouped FP8 quantization, replacing an older test implementation. The new tests verify the quantization path against a native reference, ensure compatibility with torch.compile, and validate error handling for unsupported configurations. Feedback suggests refining the test skipping logic by using is_aiter_found_and_supported() in the pytestmark to correctly skip tests when the aiter package is missing on supported hardware, rather than triggering assertion failures.

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

…_grouped_quant

mergify · 2026-07-15T04:19:45Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @AndreasKaratzas.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>

claude

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

AndreasKaratzas · 2026-08-14T06:15:34Z

/ci run

github-actions · 2026-08-14T06:15:52Z

✅ Triggered Buildkite CI #83857 for commit 296a4f75d023.

Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>

AndreasKaratzas · 2026-08-17T22:15:40Z

/ci run

github-actions · 2026-08-17T22:15:58Z

✅ Triggered Buildkite CI #84275 for commit 2b73ad5ec27f.

mergify · 2026-08-17T23:45:58Z

Hi @AndreasKaratzas, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

tjtanaa

LGTM

Resolve the .buildkite/test-amd.yaml conflicts: - Keep the Quantized Fusions AMD job this branch adds. - Drop the ROCm AITER Ops Test job. Upstream removed it in vllm-project#40938 when tests/rocm/aiter was split into tests/kernels/{attention,quantization}, so `pytest -v -s rocm/aiter/` would now collect nothing. - Keep both the streaming_input coverage from this branch and the encoder cudagraph coverage from main. Signed-off-by: Stefan Koncarevic <Stefan.Koncarevic@amd.com>

Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Wenhua Cheng <wenhua.cheng@intel.com>

Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Co-authored-by: OpenAI Codex <codex@openai.com>

Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Wyett <wyettzeng@gmail.com>

Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>

Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: khushali9 <khushali.desai9@gmail.com>

Upstream sync 26/N: merge 5fa8ca9 [ROCm][CI] Move ROCm AITER quantization tests (vllm-project#40938) (conflict)

[ROCm][CI] Move ROCm grouped quant test

87e57f3

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

mergify Bot added the rocm Related to AMD ROCm label Apr 26, 2026

github-project-automation Bot added this to AMD Apr 26, 2026

github-project-automation Bot moved this to Todo in AMD Apr 26, 2026

gemini-code-assist Bot reviewed Apr 26, 2026

View reviewed changes

Comment thread tests/kernels/quantization/rocm/aiter/test_grouped_quant.py Outdated

AndreasKaratzas changed the title ~~[ROCm][CI] Move ROCm grouped quant test~~ [ROCm][CI] Move ROCm AITER quantization tests Apr 26, 2026

AndreasKaratzas added 2 commits April 26, 2026 16:43

Move ROCm AITER quantization tests

8379322

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

Move ROCm AITER quantization tests

2fbe5de

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

mergify Bot added the ci/build label Apr 26, 2026

AndreasKaratzas added 4 commits April 26, 2026 17:01

Move ROCm AITER quantization tests

bfd4746

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

[ROCm][CI] Move ROCm AITER grouped quant

aada794

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

[ROCm][CI] Move ROCm AITER grouped quant

ccc8ca0

Signed-off-by: Andreas Karatzas <akaratza@amd.com>

Merge remote-tracking branch 'origin/main' into akaratza_ci_move_rocm…

9432abc

…_grouped_quant

mergify Bot added the needs-rebase label Jul 15, 2026

mergify Bot added the quantization label Jul 23, 2026

[ROCm][CI] Bring AITER test moves up to date

cff44c2

Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>

mergify Bot removed the needs-rebase label Aug 14, 2026

AndreasKaratzas marked this pull request as ready for review August 14, 2026 06:15

AndreasKaratzas requested review from Harry-Chen, WoosukKwon, khluu, mgoin, tjtanaa, tlrmchlsmth, yewentao256 and zyongye as code owners August 14, 2026 06:15

Merge branch 'main' into akaratza_ci_move_rocm_grouped_quant

296a4f7

claude Bot reviewed Aug 14, 2026

View reviewed changes

[ROCm][Test] Validate installed AITER MLA FP8 support

2b73ad5

Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>

AndreasKaratzas added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 17, 2026

tjtanaa approved these changes Aug 18, 2026

View reviewed changes

tjtanaa merged commit 5fa8ca9 into vllm-project:main Aug 18, 2026
57 of 60 checks passed

github-project-automation Bot moved this from Todo to Done in AMD Aug 18, 2026

AndreasKaratzas deleted the akaratza_ci_move_rocm_grouped_quant branch August 18, 2026 15:04

AndreasKaratzas mentioned this pull request Sep 5, 2026

[Feature]: Infrastructure Improvements for ROCm CI #34994

Open

14 tasks

This was referenced Sep 7, 2026

Upstream sync 25/N: merge d785eb51ce (15 commits, conflict-free) ROCm/vllm#1272

Merged

Upstream sync 26/N: merge 5fa8ca971a [ROCm][CI] Move ROCm AITER quantization tests (#40938) (conflict) ROCm/vllm#1273

Merged

eble-amd added a commit to ROCm/vllm that referenced this pull request Sep 10, 2026

Merge pull request #1273 from ROCm/rogarcia.merge-upstream-122

554a3d4

Upstream sync 26/N: merge 5fa8ca9 [ROCm][CI] Move ROCm AITER quantization tests (vllm-project#40938) (conflict)

Navigation Menu

Uh oh!

Uh oh!

[ROCm][CI] Move ROCm AITER quantization tests - #40938

[ROCm][CI] Move ROCm AITER quantization tests#40938
tjtanaa merged 10 commits into
vllm-project:mainfrom
ROCm:akaratza_ci_move_rocm_grouped_quant

AndreasKaratzas commented Apr 26, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

mergify Bot commented Jul 15, 2026

Uh oh!

claude Bot left a comment

Uh oh!

AndreasKaratzas commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

AndreasKaratzas commented Aug 17, 2026

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

mergify Bot commented Aug 17, 2026

Uh oh!

tjtanaa left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

AndreasKaratzas commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

mergify Bot commented Jul 15, 2026

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

AndreasKaratzas commented Aug 14, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

AndreasKaratzas commented Aug 17, 2026

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

mergify Bot commented Aug 17, 2026

Uh oh!

tjtanaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AndreasKaratzas commented Apr 26, 2026 •

edited

Loading