Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the DeepGemmMegaExperts modular kernel, integrating DeepGEMM's mega_moe kernel for MXFP4 MoE. The changes include the new expert class, comprehensive unit tests, and FP4 quantization utilities. Review feedback focuses on improving code quality by removing redundant math utilities in favor of existing vLLM helpers and cleaning up dead code, placeholder comments, and unimplemented methods in the new implementation.
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This was referenced Sep 16, 2026
5 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Integration for DeepGEMM MegaMoE kernel.
Weight creation/prep in the quant method is not right. I'm not sure if I should create a whole new quant method or hack up the existing create_weights or add some further processing step, .e.g.
cast_grouped_weights_to_fp4TODO: consider making "deep_gemm_mega_moe" backend?
Test Plan
Added unit test
TODO: test on mxfp4 model.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)