[MoE Refactor] Combine MoERunnerBase + DefaultMoERunner#40560
Merged
robertgshaw2-redhat merged 6 commits intovllm-project:mainfrom Apr 22, 2026
Merged
[MoE Refactor] Combine MoERunnerBase + DefaultMoERunner#40560robertgshaw2-redhat merged 6 commits intovllm-project:mainfrom
robertgshaw2-redhat merged 6 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Bill Nell <bnell@redhat.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates MoE runner logic by migrating the implementation from the now-deleted MoERunnerBase into DefaultMoERunner and registering custom operations for MoE forward passes. The review feedback identifies several critical issues: the _replace_quant_method helper fails to update the cached _fused_output_is_reduced property, which can lead to inconsistent reduction logic; the scaling logic for FP16 incorrectly ignores the routed_scaling_factor when shared experts are absent; and an assertion in the shared expert reduction path could cause crashes when shared experts are not used.
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
robertgshaw2-redhat
approved these changes
Apr 22, 2026
robertgshaw2-redhat
added
the
ready
Signed-off-by: Bill Nell <bnell@redhat.com>
baonudesifeizhai
pushed a commit
to baonudesifeizhai/vllm
that referenced
this pull request
Apr 23, 2026
…#40560) Signed-off-by: Bill Nell <bnell@redhat.com>
4 tasks
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Apr 23, 2026
…#40560) Signed-off-by: Bill Nell <bnell@redhat.com> Signed-off-by: Yifan <yzong@redhat.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…#40560) Signed-off-by: Bill Nell <bnell@redhat.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Lafunamor
pushed a commit
to Lafunamor/vllm
that referenced
this pull request
May 1, 2026
…#40560) Signed-off-by: Bill Nell <bnell@redhat.com> Signed-off-by: Adrian <info@zzit.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Now that the chunking MoE runner has been deleted, we can have a single concrete
MoERunnerclass.MoERunnerBasewithDefaultMoERunner.Test Plan
CI
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.