[ci] Make ecr authenticate non blocking

[khluu]

There are pipelines that don't configure registry to be the same as CI

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[gemini-code-assist]

Code Review

This pull request modifies the ecr_login function in the Buildkite image build script to allow the script to continue even if the AWS ECR login commands fail. Feedback suggests replacing the || true suppression with a warning message to ensure that authentication failures are visible in the logs for debugging purposes, rather than being silently ignored.

[gemini-code-assist]

Using || true to suppress errors from docker login is a risky practice because it masks legitimate failures (e.g., expired AWS credentials, network issues, or missing binaries) that will cause subsequent steps to fail with less descriptive error messages.

Since the goal is to make these logins non-blocking for environments where these registries are not configured, it is better to at least log a warning when the login fails. This provides visibility in the CI logs and aids in debugging if the build fails later due to authentication issues.

Suggested change

	aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin "$REGISTRY" || true
	aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 936637512419.dkr.ecr.us-east-1.amazonaws.com || true
	aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin "$REGISTRY" || echo "Warning: ECR Public login failed"
	aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 936637512419.dkr.ecr.us-east-1.amazonaws.com || echo "Warning: ECR login failed"