Revert "[Misc] Move pyav and soundfile to common requirements"#40276
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the av and soundfile dependencies from the general requirements/common.txt file to the optional audio extra in setup.py. This change ensures that these audio-related libraries are only installed when the audio functionality is explicitly requested. Corresponding updates were made to the ROCm test requirements to reflect the change in dependency origin. I have no feedback to provide.
ywang96
approved these changes
Apr 19, 2026
yewentao256
approved these changes
Apr 19, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
5 tasks
Copilot AI
pushed a commit
to hongbolv/vllm
that referenced
this pull request
Apr 22, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
baonudesifeizhai
pushed a commit
to baonudesifeizhai/vllm
that referenced
this pull request
Apr 23, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io>
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Apr 23, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: Yifan <yzong@redhat.com>
4 tasks
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Lafunamor
pushed a commit
to Lafunamor/vllm
that referenced
this pull request
May 1, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: Adrian <info@zzit.ch>
Copilot AI
pushed a commit
to hongbolv/vllm
that referenced
this pull request
May 7, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> (cherry picked from commit 67eb608)
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> (cherry picked from commit 1f2018b)
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> (cherry picked from commit 7ea6e40)
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://vllm-dev.slack.com/archives/C07QP347J4D/p1776586491239949?thread_ts=1776201707.050099&cid=C07QP347J4D
Reverts #39997