-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Fix MoE backend selection for LoRA (unquantized MoE) #40273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robertgshaw2-redhat
merged 9 commits into
vllm-project:main
from
de-inf:fix_lora_moe_backend
Apr 19, 2026
+90
−0
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d57b541
Fix backend selection for LoRA (unquantized MoE)
danisereb f8001c9
Cleanup tests
danisereb 4c0c318
Remove BATCHED_TRITON as option for LoRA
danisereb cdf3444
Apply the changes only for CUDA.
danisereb af6c03e
Add more tests
danisereb 077cede
Refactor tests
danisereb 6b852cd
Code review changes.
danisereb ff7e521
Remove cuda/rocm check to align with select_fp8_moe_backend
danisereb 8012f92
Fix skipif var name
danisereb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,6 +163,11 @@ def select_unquantized_moe_backend( | |
| if current_platform.is_out_of_tree(): | ||
| return UnquantizedMoeBackend.OOT, None | ||
|
|
||
| if moe_config.is_lora_enabled: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This logic is now aligned with |
||
| return UnquantizedMoeBackend.TRITON, backend_to_kernel_cls( | ||
| UnquantizedMoeBackend.TRITON | ||
| ) | ||
|
|
||
| # NOTE: the kernels are selected in the following order. | ||
| AVAILABLE_BACKENDS = _get_priority_backends(moe_config) | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This test can run on all platforms.. nothing CUDA/ROCm specific about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure about XPUs.