Skip to content

Revert "[Misc] toy_proxy_server handle min_tokens" (#39706)#40138

Draft
vllm-agent wants to merge 1 commit intovllm-project:mainfrom
vllm-agent:auto-revert/pr-39706
Draft

Revert "[Misc] toy_proxy_server handle min_tokens" (#39706)#40138
vllm-agent wants to merge 1 commit intovllm-project:mainfrom
vllm-agent:auto-revert/pr-39706

Conversation

@vllm-agent
Copy link
Copy Markdown

Revert of PR #39706

Original PR: #39706
Build: https://buildkite.com/vllm/ci/builds/61784

Reason

This PR is suspected of causing 1 CI failure(s):

  • Hyrbid SSM NixlConnector PD accuracy tests (4 GPUs) — accuracy assertion failed (measured 0.7665 vs expected 0.8)

Auto-generated

This revert was auto-generated by the CI failure analyzer.

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

PRs do not trigger a full CI run by default. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

Agent Guidelines

IMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban.

🚀

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the logic in toy_proxy_server.py that previously stripped min_tokens and min_completion_tokens from request data before sending it to a service and then restored them afterward. I have no feedback to provide as there are no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant