Skip to content

[CI Failure] Fix Plugin Tests (2 GPUs) Failure#40083

Merged
robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom
noooop:fix_Plugins
Apr 17, 2026
Merged

[CI Failure] Fix Plugin Tests (2 GPUs) Failure#40083
robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom
noooop:fix_Plugins

Conversation

@noooop
Copy link
Copy Markdown
Collaborator

@noooop noooop commented Apr 17, 2026

Purpose

Fix Plugin Tests (2 GPUs) Failure

https://buildkite.com/vllm/ci/builds/61717/steps/canvas?sid=019d9819-71e0-4ae0-a3de-733cfd32bd70&tab=output

cherry-pick from #40030 df17e6a

Test Plan

Plugin Tests (2 GPUs)

Test Result

pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@mergify mergify Bot added the frontend label Apr 17, 2026
@noooop noooop changed the title [CI Failure] fix [CI Failure] Fix Plugin Tests (2 GPUs) Failure Apr 17, 2026
@noooop noooop marked this pull request as ready for review April 17, 2026 02:02
@noooop noooop added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 17, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a to_pooling_params method to the pooling protocol in vllm/entrypoints/pooling/pooling/protocol.py, which enables the creation of PoolingParams using the task attribute from the request. No review comments were provided, so I have no feedback to offer.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 17, 2026 02:14
@robertgshaw2-redhat robertgshaw2-redhat merged commit 978a446 into vllm-project:main Apr 17, 2026
51 checks passed
@noooop noooop deleted the fix_Plugins branch April 17, 2026 04:55
bnellnm pushed a commit to neuralmagic/vllm that referenced this pull request Apr 20, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Co-authored-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
baonudesifeizhai pushed a commit to baonudesifeizhai/vllm that referenced this pull request Apr 23, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Co-authored-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
whk-lab pushed a commit to whk-lab/vllm that referenced this pull request Apr 23, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Co-authored-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Apr 27, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Co-authored-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants