[ROCm] torch 2.11 + rocclr profiler hotfix for ROCm 7.2 + aiter v0.1.12.post2#40035
[ROCm] torch 2.11 + rocclr profiler hotfix for ROCm 7.2 + aiter v0.1.12.post2#40035Rohan138 wants to merge 12 commits into
Conversation
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates the ROCm base image to version 7.2.2 and implements a torch profiler hotfix by building the Compute Language Runtime from source. Feedback suggests using an immutable commit SHA instead of a personal branch for the hotfix source to improve stability and security. Furthermore, the build configuration should explicitly set the installation prefix to /opt/rocm/ to ensure the patched libraries are correctly utilized and not shadowed by original system files.
|
|
||
| # torch profiler hotfix for 7.2.2: cherry-pick ROCm/rocm-systems#5062 and rebuild CLR | ||
| # will be removed once we move to ROCm 7.13 | ||
| ARG CLR_HOTFIX_BRANCH="users/saleelk/7.2cp2" |
There was a problem hiding this comment.
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
a9d2b4a to
d69efb1
Compare
|
CI run with the new base image: |
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
437fec3 to
ec4c422
Compare
|
Can we try to split this PR and try to ship whichever that is working first? |
|
torch 2.11 still being fixed, ROCm 7.2+CLR fix+AITER bump merged in #41386 |
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.