Skip to content

[Misc] Move pyav and soundfile to common requirements #39997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 2 commits into from
Apr 16, 2026
+6 −3
Merged

[Misc] Move pyav and soundfile to common requirements #39997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26292ab
move pyav and soundfile to common requirements
Isotr0py Apr 16, 2026
3f0b579
Merge branch 'main' into mv-pyav
Isotr0py Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions requirements/common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ pyzmq >= 25.0.0
msgspec
gguf >= 0.17.0
mistral_common[image] >= 1.11.0
av # required for audio in video IO
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Moving av (PyAV) to common requirements introduces a mandatory dependency on FFmpeg, which is a heavy system-level requirement and is typically LGPL/GPL licensed. This significantly increases the installation footprint and the potential for installation failures in minimal environments (e.g., base Docker images) for users who only require text-based inference. Furthermore, this change contradicts the PR's stated goal of isolating LGPL dependencies, as it moves an LGPL-linked library from an optional extra into the core requirements. This should remain in an optional extra like [video] or [audio]. Additionally, the requirement is unversioned here, which can lead to non-deterministic builds.

opencv-python-headless >= 4.13.0 # required for video IO
soundfile # required for audio IO
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Moving soundfile to common requirements forces a mandatory dependency on the libsndfile system library (LGPL) for all vLLM users. This introduces unnecessary system-level overhead for text-only use cases and, similar to the av dependency, contradicts the objective of keeping the base installation free of LGPL-linked libraries. It is recommended to keep this dependency within the [audio] extra to maintain modularity and a lightweight core. This requirement is also unversioned, which is a risk for build stability.

pyyaml
six>=1.16.0; python_version > '3.11' # transitive dependency of pandas that needs to be the latest version for python 3.12
setuptools>=77.0.3,<81.0.0; python_version > '3.11' # Setuptools is used by triton, we need to ensure a modern version is installed for 3.12+ so that it does not try to import distutils, which was removed in 3.12
Expand Down
5 changes: 4 additions & 1 deletion requirements/test/rocm.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ attrs==26.1.0
audioread==3.0.1
# via librosa
av==16.1.0
# via -r requirements/test/rocm.in
# via
# -r requirements/test/../common.txt
# -r requirements/test/rocm.in
azure-core==1.39.0
# via
# azure-identity
Expand Down Expand Up @@ -1331,6 +1333,7 @@ sortedcontainers==2.4.0
# via hypothesis
soundfile==0.13.1
# via
# -r requirements/test/../common.txt
# -r requirements/test/rocm.in
# genai-perf
# librosa
Expand Down
2 changes: 0 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,9 +1092,7 @@ def _read_requirements(filename: str) -> list[str]:
"instanttensor": ["instanttensor >= 0.1.5"],
"runai": ["runai-model-streamer[s3,gcs,azure] >= 0.15.7"],
"audio": [
"av",
"scipy",
"soundfile",
"mistral_common[audio]",
], # Required for audio processing
"video": [], # Kept for backwards compatibility
Expand Down
Loading