[BugFix][XPU] fix lora ops bgmv_expand size not match#39989
Merged
jikunshang merged 6 commits intovllm-project:mainfrom Apr 20, 2026
Merged
[BugFix][XPU] fix lora ops bgmv_expand size not match#39989jikunshang merged 6 commits intovllm-project:mainfrom
jikunshang merged 6 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com>
Liangliang-Ma
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the bgmv_expand function in the XPU LoRA operations to handle dimension mismatches between LoRA weights and output tensors. The implementation now correctly handles cases where the weight output dimension is smaller than the output tensor by using bgmv_expand_slice, and truncates weights when the dimension is larger, ensuring robust behavior for scenarios like padded logits. I have no feedback to provide as there were no review comments.
jikunshang
reviewed
Apr 17, 2026
Collaborator
jikunshang
left a comment
jikunshang
left a comment
There was a problem hiding this comment.
LGTM. cc @chaojun-zhang
jikunshang
approved these changes
Apr 20, 2026
bnellnm
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Apr 20, 2026
…9989) Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com> Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
baonudesifeizhai
pushed a commit
to baonudesifeizhai/vllm
that referenced
this pull request
Apr 23, 2026
…9989) Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com> Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…9989) Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com> Co-authored-by: Kunshang Ji <kunshang.ji@intel.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Lafunamor
pushed a commit
to Lafunamor/vllm
that referenced
this pull request
May 1, 2026
…9989) Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com> Co-authored-by: Kunshang Ji <kunshang.ji@intel.com> Signed-off-by: Adrian <info@zzit.ch>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…9989) Signed-off-by: Ma, Liangliang <liangliang.ma@intel.com> Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issued found with tests/entrypoints/openai/speech_to_text/test_translation_validation.py::test_basic_audio_with_lora.
error msg:
(EngineCore pid=25878) ERROR 04-07 16:03:25 [core.py:1108] bgmv_expand(buffer, lora_b_stacked, y, sampler_indices, add_inputs=True) (EngineCore pid=25878) ERROR 04-07 16:03:25 [core.py:1108] File "/opt/venv/lib/python3.12/site-packages/vllm/lora/ops/xpu_ops/lora_ops.py", line 30, in bgmv_expand (EngineCore pid=25878) ERROR 04-07 16:03:25 [core.py:1108] torch.ops._xpu_C.bgmv_expand( (EngineCore pid=25878) ERROR 04-07 16:03:25 [core.py:1108] File "/opt/venv/lib/python3.12/site-packages/torch/ops.py", line 1209, in __call_ (EngineCore pid=25878) ERROR 04-07 16:03:25 [core.py:1108] return self._op(*args, **kwargs) (EngineCore pid=25878) ERROR 04-07 16:03:25 [core.py:1108] ^^^^^^^^^^^^^^^^^^^^^^^^^ (EngineCore pid=25878) ERROR 04-07 16:03:25 [core.py:1108] RuntimeError: lora_b_weights.size(-2) must match slice_sizeThis pr would fix the size issue.