[Bugfix][ROCm]: Allow gpt_oss_mxfp4 quantization method on rocm#39754
Merged
gshtras merged 1 commit intovllm-project:mainfrom Apr 14, 2026
Merged
[Bugfix][ROCm]: Allow gpt_oss_mxfp4 quantization method on rocm#39754gshtras merged 1 commit intovllm-project:mainfrom
gpt_oss_mxfp4 quantization method on rocm#39754gshtras merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
gshtras
approved these changes
Apr 14, 2026
zxd1997066
pushed a commit
to zxd1997066/vllm
that referenced
this pull request
Apr 15, 2026
…lm-project#39754) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Signed-off-by: zengxian <xiangdong.zeng@intel.com>
whk-lab
pushed a commit
to whk-lab/vllm
that referenced
this pull request
Apr 23, 2026
…lm-project#39754) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…lm-project#39754) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#39604 added the
gpt_oss_mxfp4quantization method, but did not add it to the list ofsupported_quantizationmethods thatrocm.pymaintains. Runningvllm serve --model openai/gpt-oss-120bthus gives me the following error:This PR fixes the error. As an aside, ROCm seems to be the only platform that maintains such a list-do we know if we still want it here? I think it makes more sense for the quantization method itself to specify the supported platform(s), rather than this list at the platform level.
cc @gshtras @tjtanaa @mgoin @zyongye
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.