[CI][Metrics] Fix local_cache_hit assertion after prompt tokens metrics updates#39709
Merged
markmc merged 1 commit intovllm-project:mainfrom Apr 13, 2026
Merged
Conversation
Signed-off-by: ZhanqiuHu <zhu@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests in test_multi_connector_edge_cases.py by adjusting the expected local_cache_hit metric. The assertions in both test_full_decode_gpu_cache_hit_metrics and test_partial_decode_gpu_cache_hit_metrics have been modified to expect one fewer cache hit than previously calculated. I have no feedback to provide as no review comments were submitted.
markmc
added
ready
ZhanqiuHu
changed the title
Member
|
Thanks for the quick fix. I don't expect #37460 to restore the old behaviour If we want to account "correctly" for these recomputed tokens, we need the scheduler to report those metrics correctly rather than try to infer it 👍 |
markmc
approved these changes
Apr 13, 2026
markmc
changed the title
jonathanc-n
pushed a commit
to jonathanc-n/vllm
that referenced
this pull request
Apr 13, 2026
…cs updates (vllm-project#39709) Signed-off-by: ZhanqiuHu <zhu@redhat.com> Signed-off-by: Jonathan Chen <chenleejonathan@gmail.com>
wojciech-wais
pushed a commit
to wojciech-wais/vllm
that referenced
this pull request
Apr 13, 2026
…cs updates (vllm-project#39709) Signed-off-by: ZhanqiuHu <zhu@redhat.com>
whk-lab
pushed a commit
to whk-lab/vllm
that referenced
this pull request
Apr 23, 2026
…cs updates (vllm-project#39709) Signed-off-by: ZhanqiuHu <zhu@redhat.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…cs updates (vllm-project#39709) Signed-off-by: ZhanqiuHu <zhu@redhat.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR #38709 removed the
recomputedtoken fromPromptTokenStats.update_from_output(). When all prompt tokens are cached (local + NIXL), the scheduler reducesnum_cached_tokensby 1, which is now absorbed bylocal_cache_hitin the metric accounting. This temporarily updates the MultiConnector edge case test assertions to match the new metric semantics.Test Plan
CI runs.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.