[kv_offload+HMA][9/N]: Support lookup with multiple KV groups#39401
Open
orozery wants to merge 1 commit intovllm-project:mainfrom
Open
[kv_offload+HMA][9/N]: Support lookup with multiple KV groups#39401orozery wants to merge 1 commit intovllm-project:mainfrom
orozery wants to merge 1 commit intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the offloading scheduler in vllm/distributed/kv_transfer/kv_connector/v1/offloading/scheduler.py to support multiple KV cache groups. It initializes lookup_groups in the constructor and modifies the get_num_new_matched_tokens method to iterate through these groups, performing individual block lookups and handling request deferral or delay based on the state of blocks within each group. There are no review comments to address.
5 tasks
orozery
force-pushed
the
kv-offload-lookup-multiple-groups
branch
from
09cca7b to
587ba2a
Compare
This commit extends the offloading connector to support lookups (get_num_new_matched_tokens) where KVCacheConfig contains multiple groups. Signed-off-by: Or Ozeri <oro@il.ibm.com>
orozery
force-pushed
the
kv-offload-lookup-multiple-groups
branch
from
587ba2a to
56f4df9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the offloading connector to support lookups (
get_num_new_matched_tokens) where KVCacheConfig contains multiple groups.Currently supports only full attention groups.