[BugFix][Graph] fix: handle empty sym_shape_indices in PiecewiseBackend.#39395
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the __call__ method in vllm/compilation/piecewise_backend.py to introduce conditional logic. It now differentiates between dynamic and static input shapes based on self.sym_shape_indices. For static shapes, the method directly retrieves the first compiled range_entry from self.range_entries rather than attempting to derive a runtime shape from the arguments. This change improves the backend's flexibility to handle both dynamic and static input shape scenarios. There is no feedback to provide.
|
/cc @ProExpertProg @zou3519 PTAL. |
|
Can you add a regression test? |
Done. |
|
cc @zou3519 is it possible to ask Dynamo just not to specialize on the size 1? I feel ideally this should be fixed by Dynamo. |
I think this is possible with unbacked ints. @laithsakka is working on this I believe - faith anything to add? |
|
Richard is away this week but it'd be good to wait for @laithsakka or @BoyuanFeng to take a look before merging |
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
4600a06 to
fc20832
Compare
…nd. (vllm-project#39395) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> (cherry picked from commit db8d4a4)
…nd. (vllm-project#39395) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> (cherry picked from commit db8d4a4)
…nd. (vllm-project#39395) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…nd. (vllm-project#39395) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
…nd. (vllm-project#39395) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Purpose
FIx #39341
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.