[ROCm] Pass moe_buf to AITER to eliminate MoE output copy#39393
Closed
tpopp wants to merge 1 commit intovllm-project:mainfrom
Closed
[ROCm] Pass moe_buf to AITER to eliminate MoE output copy#39393tpopp wants to merge 1 commit intovllm-project:mainfrom
tpopp wants to merge 1 commit intovllm-project:mainfrom
Conversation
Plumb `moe_buf` and `moe_sorting_dispatch_policy` through the vLLM AITER fused MoE interface so the kernel writes directly into the caller's output buffer. This avoids a device-to-device copy of the full MoE output on every forward pass. Also adds the `VLLM_ROCM_AITER_MOE_DISPATCH_POLICY` environment variable to control the AITER MoE sorting dispatch policy. Made-with: Cursor Signed-off-by: Tres Popp <tres.popp@amd.com>
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moe_bufandmoe_sorting_dispatch_policythrough the vLLM AITER fused MoE interface so the kernel writes directly into the caller's output buffer, avoiding a device-to-device copy on every forward passVLLM_ROCM_AITER_MOE_DISPATCH_POLICYenvironment variable to control AITER MoE sorting dispatch policyTest plan
Made with Cursor