[MoE Refactor] Remove MoE DP chunking#39107
Merged
robertgshaw2-redhat merged 22 commits intovllm-project:mainfrom Apr 14, 2026
Merged
[MoE Refactor] Remove MoE DP chunking#39107robertgshaw2-redhat merged 22 commits intovllm-project:mainfrom
robertgshaw2-redhat merged 22 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Bill Nell <bnell@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the VLLM_MOE_DP_CHUNK_SIZE and VLLM_ENABLE_MOE_DP_CHUNK environment variables, refactoring MoE chunking to rely on the scheduler's max_num_batched_tokens. It eliminates ChunkingMoERunner and simplifies related logic in the runner factory and shared experts. Feedback indicates that defaulting max_num_tokens to 0 in FusedMoEConfig causes an assertion failure if not explicitly set, which may break external integrations.
Signed-off-by: Bill Nell <bnell@redhat.com>
bnellnm
requested review from
WoosukKwon,
mgoin,
pavanimajety,
tjtanaa,
tlrmchlsmth and
yewentao256
as code owners
7 tasks
robertgshaw2-redhat
added
the
ready-run-all-tests
Collaborator
|
we should set the default max-num-batched-tokens to something smaller if we detect deepep-ll |
bnellnm
changed the title
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Collaborator
|
LGTM. @elvircrn can you do a sanity check on gb? |
robertgshaw2-redhat
added
the
ready
Collaborator
|
shouldnt this also delete the ChunkingMoERunner file? |
Collaborator
|
triggering a full CI run now |
robertgshaw2-redhat
added
the
ready-run-all-tests
Collaborator
Author
I thought I did. Thanks for reminding me. |
Signed-off-by: Bill Nell <bnell@redhat.com>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
robertgshaw2-redhat
merged commit e1e318a
into
vllm-project:main
142 of 144 checks passed
vllm-agent
pushed a commit
to vllm-agent/vllm
that referenced
this pull request
Apr 15, 2026
This reverts commit e1e318a.
zxd1997066
pushed a commit
to zxd1997066/vllm
that referenced
this pull request
Apr 15, 2026
Signed-off-by: Bill Nell <bnell@redhat.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com> Signed-off-by: zengxian <xiangdong.zeng@intel.com>
whk-lab
pushed a commit
to whk-lab/vllm
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Bill Nell <bnell@redhat.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Bill Nell <bnell@redhat.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Apr 29, 2026
**Commit range:** `6f786f2`..`d886c26` 1. Fix 'DPMetadata' object has no attribute 'max_tokens_across_dp_cpu' by vllm-project/vllm#39107 2. Fix 'Indexer' object has no attribute 'wk' by vllm-project/vllm#38928 3. Fix 'float' object has no attribute 'language_model' by vllm-project/vllm#39240 ### What this PR does / why we need it? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.19.0 - vLLM main: vllm-project/vllm@6f786f2 --------- Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com> Signed-off-by: Meihan-chen <zr010426ztt@outlook.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove DP chunking MoE runner. Use
max_num_batched_tokensas default formax_num_tokensinFusedMoEConfig.Test Plan
CI
Ran DeepEP related tests/kernels/moe tests locally.
Test Result
cc @robertgshaw2-redhat , @tlrmchlsmth
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)