[Attention][MLA] Re-enable FA4 as default MLA prefill backend#38819
Merged
LucasWilkinson merged 2 commits intomainfrom Apr 6, 2026
Merged
[Attention][MLA] Re-enable FA4 as default MLA prefill backend#38819LucasWilkinson merged 2 commits intomainfrom
LucasWilkinson merged 2 commits intomainfrom
Conversation
…o TRT-LL…" This reverts commit 2c734ed.
MatthewBonanni
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
MatthewBonanni
added
the
ready
MatthewBonanni
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
MatthewBonanni
changed the title
yewentao256
approved these changes
Apr 6, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Apr 6, 2026
ShawnWeiChew
pushed a commit
to ShawnWeiChew/vllm
that referenced
this pull request
Apr 7, 2026
askliar
pushed a commit
to netanel-haber/vllm
that referenced
this pull request
Apr 7, 2026
askliar
pushed a commit
to netanel-haber/vllm
that referenced
this pull request
Apr 7, 2026
askliar
pushed a commit
to netanel-haber/vllm
that referenced
this pull request
Apr 7, 2026
jacob-lou
pushed a commit
to jacob-lou/vllm
that referenced
this pull request
Apr 7, 2026
…roject#38819) Signed-off-by: Jacob Lou <jacoblou0924@gmail.com>
USTCKAY
pushed a commit
to USTCKAY/vllm
that referenced
this pull request
Apr 7, 2026
…roject#38819) Signed-off-by: Song Kai <songkai05@baidu.com>
rishitdholakia13
pushed a commit
to rishitdholakia13/vllm
that referenced
this pull request
Apr 7, 2026
…roject#38819) Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
…roject#38819) Signed-off-by: Rishi Puri <riship@nvidia.com>
big-yellow-duck
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #38562
NaN issue resulting in correctness problems for MLA models #36763 has been resolved by updating FA4 (#38690) to capture the upstream fix Dao-AILab/flash-attention@0293155
This PR makes FA4 the default again due to its superior performance (see benchmarks in #34732)