Revert "[Perf] DSV3.2 Indexer Fused Weights Projection" (#38684)#38806
Draft
vllm-agent wants to merge 1 commit intovllm-project:mainfrom
Draft
Revert "[Perf] DSV3.2 Indexer Fused Weights Projection" (#38684)#38806vllm-agent wants to merge 1 commit intovllm-project:mainfrom
vllm-agent wants to merge 1 commit intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the DeepSeek model implementation by decoupling the fused 'wk' and 'weights_proj' linear layers into separate components in 'deepseek_v2.py' and updating the corresponding weight loading mappings in 'deepseek_mtp.py' and 'deepseek_v2.py'. I have no feedback to provide as there are no review comments.
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of #38684
This reverts commit 5f96f9a (PR #38684).
Reason
Nightly CI build #59406 detected 1 new failure linked to this PR:
KeyError: 'model.layers.0.self_attn.indexer.wk_weights_proj.weight_scale_inv'indeepseek_v2.py:1516during model loading of DeepSeek-V3.2The fused weights projection changes introduced new weight parameter names that do not exist in the model checkpoint, causing both TP and DP test variants to fail with
RuntimeError: Server exited unexpectedly.Auto-generated by CI failure analyzer