only patch runtime_env for torch >= 2.10#38763
Merged
zou3519 merged 1 commit intovllm-project:mainfrom Apr 7, 2026
Merged
Conversation
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
Lucaskabela
approved these changes
Apr 2, 2026
Contributor
Lucaskabela
left a comment
Lucaskabela
left a comment
There was a problem hiding this comment.
Thanks for the catch and apologies for the oversight on this
BowenBao
approved these changes
Apr 7, 2026
Contributor
BowenBao
left a comment
BowenBao
left a comment
There was a problem hiding this comment.
Thanks. cc @robertgshaw2-redhat , @tjtanaa
Contributor
|
I wholeheartedly agree. For some OOT backends, such as Ascend, are still using torch==2.9.0. hope can merge it |
zou3519
approved these changes
Apr 7, 2026
jacob-lou
pushed a commit
to jacob-lou/vllm
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Signed-off-by: Jacob Lou <jacoblou0924@gmail.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IIUC #37234 added a patch for #30518 so the transformers backend test works with
can_return_tuple, but theGraphRuntimeEnvandGraphCaptureOutputclasses were introduced for torch 2.10 onwards. To preserve backwards compatibility, can we gate this patch behind a torch >= 2.10 check? cc @Lucaskabela @zou3519Motivation: ROCm only moved to torch 2.10 recently via #38252, and we're still testing some vllm mainline builds against older Pytorch versions to check for regressions across ROCm/Pytorch/Triton. I think some other OOT backends (
vllm-tpu/vllm-gaudi) haven't bumped Pytorch versions yet as well.Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.