[ROCm][Bugfix] Fix ROCm runtime failure due to missing symbol#38750
[ROCm][Bugfix] Fix ROCm runtime failure due to missing symbol#38750vllm-bot merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
There was a problem hiding this comment.
Code Review
This pull request restricts the silu_and_mul_per_block_quant operation to non-ROCm environments by adding preprocessor guards in the header and binding files. A review comment correctly identifies that the macro IS_ROCM used in csrc/ops.h is inconsistent with the USE_ROCM macro used in the rest of the project, which would prevent the function from being properly hidden during ROCm builds.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Gregory Shtrasberg <156009573+gshtras@users.noreply.github.com>
|
Both these CI errors look unrelated. One is a type mismatch in test level, and the other is a trt related error. Update: found one of them: #37831 (comment) |
|
please rebase the main |
Sure but is there any reason for that? Failures are not related. Why rebase and waste resources? |
We can cancel AMD CI if we want to. Usually, it is helpful to rebase the PR to see if the passes in case if we missed something. Moreover, some of us reviewers might not be the expert of the topic and would like to help to merge critical PRs. I am not sure if that's the intention, but that's the case for some other reviewers. Some errors could also be hidden and does not surface as correct error messages. So depending on the importance of the test cases, we could sometime not able force merge PRs and has to wait until the test are resolved. This is to ensure that we don't keep on introducing code which could make triaging harder. (This is a per case basis, I don't know if there is any clear policy) |
Follow up for #32996
Failed to import from vllm._C with ImportError('/projects/ROCm/vllm_upstream/vllm/_C.abi3.so: undefined symbol: _Z28silu_and_mul_per_block_quantRN2at6TensorERKS0_S1_lSt8optionalIS0_Eb')The file is not built for ROCm, so the import of torch._C fails