[Quantization] Rename mxfp4 quant layer and oracle to gpt_oss_mxfp4#38683
Closed
zyongye wants to merge 1 commit intovllm-project:mainfrom
Closed
[Quantization] Rename mxfp4 quant layer and oracle to gpt_oss_mxfp4#38683zyongye wants to merge 1 commit intovllm-project:mainfrom
zyongye wants to merge 1 commit intovllm-project:mainfrom
Conversation
Rename the GPT-OSS-specific MXFP4 quantization files and classes to make ownership explicit: - oracle/mxfp4.py → oracle/gpt_oss_mxfp4.py; Mxfp4MoeBackend → GptOssMxfp4MoeBackend - quantization/mxfp4.py → quantization/gpt_oss_mxfp4.py; Mxfp4Config → GptOssMxfp4Config, Mxfp4MoEMethod → GptOssMxfp4MoEMethod - get_name() now returns "gpt_oss_mxfp4"; registry keeps "mxfp4" alias for backward compat with existing model JSON configs - Update all importers (compressed_tensors_moe, quark_moe, __init__, layer.py, gpt_oss.py) Kernel class names are unchanged. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Yongye Zhu <yongyezhu@meta.com> Signed-off-by: Yongye Zhu <zyy1102000@gmail.com>
zyongye
requested review from
mgoin,
pavanimajety,
robertgshaw2-redhat,
tjtanaa,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames and namespaces the mxfp4 quantization components to gpt_oss_mxfp4 across the model executor and quantization layers. Key changes include renaming the Mxfp4MoeBackend enum to GptOssMxfp4MoeBackend, updating the quantization configuration and method classes to use the gpt_oss_mxfp4 prefix, and adjusting the gpt_oss model implementation to recognize the new quantization name. I have no feedback to provide.
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Member
Author
github-project-automation
Bot
moved this from To Triage
to Done
in gpt-oss Issues & Enhancements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the GPT-OSS-specific MXFP4 quantization files and classes to make ownership explicit:
Kernel class names are unchanged.
Purpose
Test Plan
GPT-OSS-12OB gpqa with reasoning effort low
Test Result
test passed
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.