-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Add nightly b200 test for spec decode eagle correctness #38577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3c8a59d
Add nightly b200 test for spec decode eagle correctness
puririshi98 e7491ba
Merge branch 'main' into patch-8
puririshi98 a75cfd9
Merge branch 'main' into patch-8
puririshi98 5d7eb1e
Merge branch 'main' into patch-8
puririshi98 e3b6c8d
Merge branch 'main' into patch-8
puririshi98 558630c
Merge branch 'main' into patch-8
puririshi98 b58fc66
Merge branch 'main' into patch-8
puririshi98 49f0ee4
Merge branch 'main' into patch-8
puririshi98 b26e597
Update spec_decode.yaml
puririshi98 962ee48
Merge branch 'main' into patch-8
puririshi98 f866bd1
Merge branch 'main' into patch-8
puririshi98 7041559
Merge branch 'main' into patch-8
puririshi98 2bbb1c9
Merge branch 'main' into patch-8
puririshi98 fffad1e
Update spec_decode.yaml
puririshi98 2623ae4
Merge branch 'main' into patch-8
puririshi98 d7d9ffe
Merge branch 'main' into patch-8
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,17 @@ steps: | |
| commands: | ||
| - pytest -v -s v1/e2e/spec_decode -k "eagle_correctness" | ||
|
|
||
| - label: Spec Decode Eagle Nightly B200 | ||
| timeout_in_minutes: 30 | ||
| device: b200 | ||
| optional: true | ||
| source_file_dependencies: | ||
| - vllm/v1/spec_decode/ | ||
| - vllm/v1/worker/gpu/spec_decode/ | ||
| - tests/v1/e2e/spec_decode/ | ||
| commands: | ||
| - pytest -v -s v1/e2e/spec_decode -k "eagle_correctness" | ||
|
benchislett marked this conversation as resolved.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This nightly should cover more than just the eagle correctness. Ideally we'd check at least MTP, maybe also draft model.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed |
||
|
|
||
| - label: Spec Decode Speculators + MTP | ||
| timeout_in_minutes: 30 | ||
| device: h200_18gb | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.