-
-
Notifications
You must be signed in to change notification settings - Fork 20.1k
[Kernels][MoE] Fix legacy_routing to use bitmatrix-based routing path #38504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e3cf764
[Engine] Fix engine stalling when async KV offload defers block frees
AndreasKaratzas 8c08e6e
Fix legacy_routing to use bitmatrix-based routing path
AndreasKaratzas c7fa8c0
Merge remote-tracking branch 'origin/main' into akaratza_fix_legacy_r…
AndreasKaratzas e302ad2
Reset scheduler changes to origin/main, keep only GPT OSS changes
AndreasKaratzas eb5c162
Merge remote-tracking branch 'origin/main' into akaratza_fix_legacy_r…
AndreasKaratzas bb7e1f0
Merge remote-tracking branch 'origin/main' into akaratza_fix_legacy_r…
AndreasKaratzas 86f5166
[GPT] Deprecate legacy routing
AndreasKaratzas 0c99ffe
Merge remote-tracking branch 'origin/main' into akaratza_fix_legacy_r…
AndreasKaratzas 7776b13
Merge remote-tracking branch 'origin/main' into akaratza_fix_legacy_r…
AndreasKaratzas 1618fb6
[ROCm] Fix pack_bitmatrix spurious bit, CDNA4 test padding, and gfx95…
AndreasKaratzas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after you remove this
legacy_routing_from_sparsematrixis not used any more. Let's remove it.Moreover, please disclose the accuracy of the models.
I am not familiar with this part of the code.
CC @robertgshaw2-redhat @bnellnm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed that legacy routing logic. I enabled also GPQA Eval tests too for GPT-OSS accuracy.