[CI] Fix SPLADE pooler test broken by #38139#38495
Merged
noooop merged 2 commits intovllm-project:mainfrom Mar 30, 2026
Merged
Conversation
Replace `types.SimpleNamespace` mock with real `PoolingMetadata` dataclass in `test_splade_pooler_matches_reference_formula`. The test broke after PR vllm-project#38139 added `get_prompt_token_ids_cpu()` to PoolingMetadata and updated SPLADESparsePooler to call it — the SimpleNamespace mock lacked this method. Using the real dataclass makes the test resilient to future interface changes and matches the pattern used in production warmup code. Signed-off-by: vllm-contributor <contributor@vllm.ai> Signed-off-by: haosdent <haosdent@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the SPLADE sparse pooler tests by replacing types.SimpleNamespace with the PoolingMetadata class and adding necessary imports. The feedback identifies a potential issue with object aliasing when initializing pooling_params using list multiplication and suggests using a list comprehension instead to ensure each element is a unique instance.
Contributor
Author
|
@yewentao256 Can you help to take a look, many thanks! |
noooop
approved these changes
Mar 30, 2026
github-actions
bot
added
the
ready
Elm8116
pushed a commit
to Elm8116/vllm
that referenced
this pull request
Mar 30, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: Elham Harirpoush <elham.harirpoush@arm.com>
3 tasks
benenzhu
pushed a commit
to benenzhu/vllm
that referenced
this pull request
Mar 31, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: zhutaoyu <zhutaoyu97@gmail.com>
khluu
pushed a commit
that referenced
this pull request
Mar 31, 2026
neweyes
pushed a commit
to neweyes/vllm
that referenced
this pull request
Mar 31, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: neweyes <328719365@qq.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>
bhargav-patel-29
pushed a commit
to Bharatgen-Tech/vllm
that referenced
this pull request
Apr 1, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: bhargav-patel-29 <bhargav.patel@tihiitb.org>
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Apr 3, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com>
liuchenbing2026
pushed a commit
to liuchenbing2026/vllm
that referenced
this pull request
Apr 4, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com>
rishitdholakia13
pushed a commit
to rishitdholakia13/vllm
that referenced
this pull request
Apr 7, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
big-yellow-duck
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Apr 8, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 10, 2026
…t#38495) Signed-off-by: haosdent <haosdent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types.SimpleNamespacemock with realPoolingMetadataintest_splade_pooler_matches_reference_formulaget_prompt_token_ids_cpu()toPoolingMetadatabut the test'sSimpleNamespacemock lacked this method, causingAttributeErrorSupersedes revert PR #38490.
Test plan
pytest tests/models/language/pooling/test_splade_sparse_pooler.py -xvspasses locally