Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Gemma3nAudioInputs schema in vllm/model_executor/models/gemma3n_mm.py to explicitly mark the sequence dimension 's' as dynamic for both input_features_padded and input_features_mask. I have no feedback to provide.
e470c66 to
24a1039
Compare
|
bump — 2-line fix, same pattern as #31223. |
|
I was having the same issue. Thanks for the PR. |
|
Rebased this onto current main to rerun the stale pre-run gate. The previous failure was from 2026-03-30 and required either a ready label or 4+ merged PRs; the author now has 5 merged vLLM PRs, so the gate should pass on the refreshed run. Local checks: py_compile on vllm/model_executor/models/gemma3n_mm.py and git diff --check. |
24a1039 to
77afc38
Compare
Gemma3nAudioInputs declares input_features_padded and input_features_mask with fixed sequence-length dimensions. When two concurrent requests carry audio clips of different durations, TensorSchema.validate() sees mismatched shapes and kills EngineCore with a ValueError. Mark the sequence-length dimension as dynamic so the validator allows variable-length audio inputs in the same batch, matching the pattern used by MiniCPM-o, Qwen2Audio, and AudioFlamingo3 (PR vllm-project#31223). Fixes vllm-project#38297 Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
77afc38 to
02c44f2
Compare
|
Rebased this branch onto current Validation: |
|
Closing this during PR backlog cleanup. This one has not received human maintainer signal and is lower priority than the remaining vLLM PRs that are approved, actively reviewed, or more recent/high-signal. I can reopen or refresh it if maintainers want this specific fix. |
Summary
Gemma3nAudioInputsdeclaresinput_features_paddedandinput_features_maskwith fixed sequence-length dimensions. When two concurrent requests carry audio clips of different durations,TensorSchema.validate()sees mismatched shapes and kills EngineCore:The fix adds
dynamic_dims={"s"}to both fields, matching the pattern established by PR #31223 for MiniCPM-o, Qwen2Audio, and AudioFlamingo3.Changes
vllm/model_executor/models/gemma3n_mm.py: Adddynamic_dims={"s"}toinput_features_paddedandinput_features_maskinGemma3nAudioInputsTest Plan
Fixes #38297