[Misc] Rename think_start_str/think_end_str to reasoning_start_str/reasoning_end_str#38242
Conversation
…reasoning_end_str Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…reasoning_end_str Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…reasoning_end_str Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
|
Documentation preview: https://vllm--38242.org.readthedocs.build/en/38242/ |
There was a problem hiding this comment.
Code Review
This pull request renames think_start_str and think_end_str to reasoning_start_str and reasoning_end_str across the codebase, including documentation, tests, and core configuration files, to improve naming consistency. However, an offline inference example in docs/features/reasoning_outputs.md was not updated and still uses the old parameter names, which will cause a TypeError. Additionally, it is suggested to consider renaming other related terms like thinking_token_budget and ThinkingTokenBudgetLogitsProcessor for further consistency.
…reasoning_end_str Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
|
I noticed a couple of things: 1. Missing rename in This file still references the old property names and would break after this PR merges: 2. Breaking change for Since the |
…reasoning_end_str Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
|
@sfeng33 Thanks for the review. Regarding the second issue, since the preceding PR was merged not long ago and hasn’t been included in any released version yet, I’d like to merge this PR as soon as possible. |
…asoning_end_str (vllm-project#38242) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…asoning_end_str (vllm-project#38242) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>
…asoning_end_str (vllm-project#38242) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
…asoning_end_str (vllm-project#38242) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…asoning_end_str (vllm-project#38242) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…asoning_end_str (vllm-project#38242) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Purpose
follow up #20859
Rename think_start_str/think_end_str to reasoning_start_str/reasoning_end_str.
Avoid being too tightly coupled to
<think>. Some models experiment with fields like<seed:think>, or patterns such as</think>\n<answer>\n.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.