Skip to content

[Misc] Rename think_start_str/think_end_str to reasoning_start_str/reasoning_end_str#38242

Merged
njhill merged 6 commits intovllm-project:mainfrom
chaunceyjiang:rename_think_start_end_str
Apr 1, 2026
Merged

[Misc] Rename think_start_str/think_end_str to reasoning_start_str/reasoning_end_str#38242
njhill merged 6 commits intovllm-project:mainfrom
chaunceyjiang:rename_think_start_end_str

Conversation

@chaunceyjiang
Copy link
Copy Markdown
Collaborator

@chaunceyjiang chaunceyjiang commented Mar 26, 2026

Purpose

follow up #20859
Rename think_start_str/think_end_str to reasoning_start_str/reasoning_end_str.

Avoid being too tightly coupled to <think>. Some models experiment with fields like <seed:think>, or patterns such as </think>\n<answer>\n.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

…reasoning_end_str

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…reasoning_end_str

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…reasoning_end_str

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2026

Documentation preview: https://vllm--38242.org.readthedocs.build/en/38242/

@mergify mergify bot added documentation Improvements or additions to documentation v1 labels Mar 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames think_start_str and think_end_str to reasoning_start_str and reasoning_end_str across the codebase, including documentation, tests, and core configuration files, to improve naming consistency. However, an offline inference example in docs/features/reasoning_outputs.md was not updated and still uses the old parameter names, which will cause a TypeError. Additionally, it is suggested to consider renaming other related terms like thinking_token_budget and ThinkingTokenBudgetLogitsProcessor for further consistency.

Comment thread docs/features/reasoning_outputs.md
…reasoning_end_str

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang chaunceyjiang changed the title [Rename] Rename think_start_str/think_end_str to reasoning_start_str/reasoning_end_str [Misc] Rename think_start_str/think_end_str to reasoning_start_str/reasoning_end_str Mar 26, 2026
@sfeng33
Copy link
Copy Markdown
Contributor

sfeng33 commented Mar 26, 2026

I noticed a couple of things:

1. Missing rename in tests/v1/logits_processors/test_correctness.py

This file still references the old property names and would break after this PR merges:

tests/v1/logits_processors/test_correctness.py:106:    think_start_token_ids = [THINK_START_TOKEN_ID]
tests/v1/logits_processors/test_correctness.py:107:    think_end_token_ids = [THINK_END_TOKEN_ID]
tests/v1/logits_processors/test_correctness.py:494:        start_tokens = tb_processor.think_start_token_ids
tests/v1/logits_processors/test_correctness.py:521:        end_tokens = tb_processor.think_end_token_ids

2. Breaking change for --reasoning-config JSON input

Since the @config decorator uses extra="forbid", existing deployments passing {"think_start_str": "<think>", "think_end_str": "</think>"} via --reasoning-config will get a validation error after upgrading.

…reasoning_end_str

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Copy Markdown
Collaborator Author

@sfeng33 Thanks for the review. Regarding the second issue, since the preceding PR was merged not long ago and hasn’t been included in any released version yet, I’d like to merge this PR as soon as possible.

@chaunceyjiang chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 31, 2026
@chaunceyjiang chaunceyjiang added this to the v0.19.0 cherry picks milestone Mar 31, 2026
Copy link
Copy Markdown
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njhill njhill merged commit cbe7d18 into vllm-project:main Apr 1, 2026
54 checks passed
khluu pushed a commit that referenced this pull request Apr 1, 2026
…asoning_end_str (#38242)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
(cherry picked from commit cbe7d18)
yzong-rh pushed a commit to yzong-rh/vllm that referenced this pull request Apr 3, 2026
…asoning_end_str (vllm-project#38242)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
rishitdholakia13 pushed a commit to rishitdholakia13/vllm that referenced this pull request Apr 7, 2026
…asoning_end_str (vllm-project#38242)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>
puririshi98 pushed a commit to puririshi98/vllm that referenced this pull request Apr 7, 2026
…asoning_end_str (vllm-project#38242)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Rishi Puri <riship@nvidia.com>
big-yellow-duck pushed a commit to EmbeddedLLM/vllm that referenced this pull request Apr 8, 2026
…asoning_end_str (vllm-project#38242)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request Apr 9, 2026
…asoning_end_str (vllm-project#38242)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
EricccYang pushed a commit to EricccYang/vllm that referenced this pull request Apr 10, 2026
…asoning_end_str (vllm-project#38242)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants