Skip to content

[feature] Implement reasoning_effort#38204

Draft
chaunceyjiang wants to merge 3 commits intovllm-project:mainfrom
chaunceyjiang:reasoning_effort
Draft

[feature] Implement reasoning_effort#38204
chaunceyjiang wants to merge 3 commits intovllm-project:mainfrom
chaunceyjiang:reasoning_effort

Conversation

@chaunceyjiang
Copy link
Copy Markdown
Collaborator

@chaunceyjiang chaunceyjiang commented Mar 26, 2026

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extends the reasoning_effort options to include 'xhigh' and refactors the logic for setting thinking_token_budget based on the chosen reasoning_effort. The review suggests improving the readability and maintainability of the new logic by using a dictionary lookup instead of an if/elif chain. Additionally, it highlights a potential regression where the include_reasoning=False setting for reasoning_effort='none' was removed and should be restored.

Comment thread vllm/entrypoints/openai/chat_completion/protocol.py
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant