[feature] Implement reasoning_effort#38204
Draft
chaunceyjiang wants to merge 3 commits intovllm-project:mainfrom
Draft
[feature] Implement reasoning_effort#38204chaunceyjiang wants to merge 3 commits intovllm-project:mainfrom
chaunceyjiang wants to merge 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
3 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request extends the reasoning_effort options to include 'xhigh' and refactors the logic for setting thinking_token_budget based on the chosen reasoning_effort. The review suggests improving the readability and maintainability of the new logic by using a dictionary lookup instead of an if/elif chain. Additionally, it highlights a potential regression where the include_reasoning=False setting for reasoning_effort='none' was removed and should be restored.
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.