Disable dual stream execution of input projection for Qwen3#38152
Merged
zou3519 merged 1 commit intovllm-project:mainfrom Mar 26, 2026
Merged
Disable dual stream execution of input projection for Qwen3#38152zou3519 merged 1 commit intovllm-project:mainfrom
zou3519 merged 1 commit intovllm-project:mainfrom
Conversation
5 tasks
Signed-off-by: Xin Yang <xyangx@amazon.com>
b73fec8 to
5f1ce9c
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the input projection logic within the Qwen3_5 and Qwen3_Next models. It removes the custom gdn_in_proj operation, its fake implementation, and the associated _forward_in_proj method that utilized maybe_execute_in_parallel. The input projection now directly calls self.in_proj_qkvz and self.in_proj_ba instead of relying on the custom operation. There are no review comments to address.
Contributor
Author
zou3519
approved these changes
Mar 25, 2026
Collaborator
zou3519
left a comment
There was a problem hiding this comment.
thanks, sorry for the trouble
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
…ject#38152) Signed-off-by: Xin Yang <xyangx@amazon.com>
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Mar 27, 2026
…ject#38152) Signed-off-by: Xin Yang <xyangx@amazon.com>
malaiwah
pushed a commit
to malaiwah/vllm
that referenced
this pull request
Mar 27, 2026
…ject#38152) Signed-off-by: Xin Yang <xyangx@amazon.com> Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently dual stream execution requires custom ops that passes the layer_name as a string. This will regress cold compile times by ~4x. So this PR temporarily revert dual stream optimization in Qwen3 and Qwen3.5 models.
TODO: Re-enable dual stream after #38123 and upgrade to Pytorch 2.11.
Test Plan
Tested with Qwen3 and Qwen3.5 models.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.