Skip to content

Various Transformers v5 fixes#38127

Merged
DarkLight1337 merged 5 commits intovllm-project:mainfrom
hmellor:more-v5-fixes
Mar 26, 2026
Merged

Various Transformers v5 fixes#38127
DarkLight1337 merged 5 commits intovllm-project:mainfrom
hmellor:more-v5-fixes

Conversation

@hmellor
Copy link
Copy Markdown
Member

@hmellor hmellor commented Mar 25, 2026

  • Add an alias for transformers.image_processing_utils_fast in the offline mode test
  • Remove the vendored Olmo3 config as mentioned in https://github.com/vllm-project/vllm/pull/24534/changes#r2339434281 because this model has been released in Transformers since v4.57.0
  • Fix sliding window configuration error in Qwen1.5 testing model (they set it to 0 instead of None which doesn't actually disable sliding window)
  • Stop DeepSeekVL2Config from passing an invalid value to DeepSeekV2Confg (DeepSeekV2 always has MLA but DeepSeekVL2 does not)

hmellor added 4 commits March 25, 2026 18:29
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify mergify bot added the deepseek Related to DeepSeek models label Mar 25, 2026
@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 25, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several changes, including updating aliased module patterns for image processing utilities, handling sliding_window=0 in model configurations by converting it to None, and refactoring Olmo3Config to use the upstream transformers library instead of a custom vLLM implementation. Additionally, a check was added in deepseek_vl2.py to remove kv_lora_rank if its value is None before passing it to DeepseekV2Config. A review comment suggests that modifying the language_config dictionary in-place in deepseek_vl2.py could lead to unexpected side effects and recommends using a copy of the dictionary instead.

Comment on lines +117 to 120
# remove kv_lora_rank if not specified, passing None is prohibited
if language_config.get("kv_lora_rank") is None:
language_config.pop("kv_lora_rank", None)
self.text_config = DeepseekV2Config(**language_config)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Modifying the language_config dictionary in-place can lead to unexpected side effects for the caller if they reuse the kwargs dictionary. It's safer to work with a copy of the dictionary to avoid such issues.

Suggested change
# remove kv_lora_rank if not specified, passing None is prohibited
if language_config.get("kv_lora_rank") is None:
language_config.pop("kv_lora_rank", None)
self.text_config = DeepseekV2Config(**language_config)
# remove kv_lora_rank if not specified, passing None is prohibited
language_config_copy = language_config.copy()
if language_config_copy.get("kv_lora_rank") is None:
language_config_copy.pop("kv_lora_rank", None)
self.text_config = DeepseekV2Config(**language_config_copy)

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 25, 2026 17:49
@DarkLight1337 DarkLight1337 merged commit 3c3c084 into vllm-project:main Mar 26, 2026
63 checks passed
@hmellor hmellor deleted the more-v5-fixes branch March 26, 2026 00:15
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Mar 26, 2026
RhizoNymph pushed a commit to RhizoNymph/vllm that referenced this pull request Mar 26, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
HenryTangDev pushed a commit to HenryTangMain/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
malaiwah pushed a commit to malaiwah/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc pushed a commit to nithinvc/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Etelis pushed a commit to Etelis/vllm that referenced this pull request Mar 29, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Mar 30, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang pushed a commit to EricccYang/vllm that referenced this pull request Apr 1, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: EricccYang <yangyang4991@gmail.com>
bhargav-patel-29 pushed a commit to Bharatgen-Tech/vllm that referenced this pull request Apr 1, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: bhargav-patel-29 <bhargav.patel@tihiitb.org>
liuchenbing2026 pushed a commit to liuchenbing2026/vllm that referenced this pull request Apr 4, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
rishitdholakia13 pushed a commit to rishitdholakia13/vllm that referenced this pull request Apr 7, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>
puririshi98 pushed a commit to puririshi98/vllm that referenced this pull request Apr 7, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Rishi Puri <riship@nvidia.com>
big-yellow-duck pushed a commit to EmbeddedLLM/vllm that referenced this pull request Apr 8, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request Apr 9, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants