Repository navigation
[Bugfix][Tool Parser] Fix Hunyuan A13B nested JSON tool streaming #38103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
vineetatiwari27
wants to merge
2
commits into
vllm-project:main
from
vineetatiwari27:fix/hunyuan-a13b-nested-json-streaming
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new approach using
_extract_tool_arguments_textand_scan_braced_json_objectcorrectly handles nested JSON, which is a great improvement. However, this implementation introduces a performance concern. On each call (for each new token), these functions re-scan a large portion of the growingcurrent_text. This leads to an overall quadratic time complexity (O(N^2)) for parsing the arguments stream, where N is the length of the arguments. In a performance-critical library like vLLM, this can be a significant issue for tool calls with large arguments.Consider refactoring this to use a stateful streaming parser. The parser's state (current position, brace depth, etc.) could be stored in
self.streaming_stateand updated incrementally with each new token, avoiding the need to re-scan previously processed text. This would bring the complexity down to linear time (O(N)).