Fix offline mode test for Transformers v5#38095
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 25, 2026
Merged
Fix offline mode test for Transformers v5#38095DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
DarkLight1337,
NickLucche,
aarnphm and
robertgshaw2-redhat
as code owners
DarkLight1337
approved these changes
Mar 25, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the tests/entrypoints/offline_mode/test_offline_mode.py file. It introduces the regex library and modifies the _re_import_modules function to use regular expressions for identifying aliased modules. This change enhances the flexibility of module aliasing detection by replacing simple string matching with pattern matching, specifically adding support for image_processing modules. There is no feedback to provide as no review comments were made.
github-actions
bot
added
the
ready
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
malaiwah
pushed a commit
to malaiwah/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>
bhargav-patel-29
pushed a commit
to Bharatgen-Tech/vllm
that referenced
this pull request
Apr 1, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: bhargav-patel-29 <bhargav.patel@tihiitb.org>
liuchenbing2026
pushed a commit
to liuchenbing2026/vllm
that referenced
this pull request
Apr 4, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
rishitdholakia13
pushed a commit
to rishitdholakia13/vllm
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
big-yellow-duck
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Apr 8, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fast modules for image processing were recently removed and consolidated so there is only a single path.
Aliases for the old
image_processing_..._fastmodules were added. These need the same treatment astokenization_utilsin this test because they cannot be directly reloaded.