Fix Plamo 2/3 & LFM2 for Transformers v5#38090
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 25, 2026
Merged
Fix Plamo 2/3 & LFM2 for Transformers v5#38090DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Lfm2MLP class in vllm/model_executor/models/lfm2.py by renaming the ff_dim parameter to intermediate_size for improved clarity and consistency across its definition and usage. Additionally, it enhances type hinting in vllm/model_executor/models/plamo2.py and vllm/model_executor/models/plamo3.py by moving the Plamo2Config and Plamo3Config class definitions into if TYPE_CHECKING: blocks and updating corresponding type annotations to use forward references. There are no review comments to address.
DarkLight1337
approved these changes
Mar 25, 2026
github-actions
bot
added
the
ready
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
7 tasks
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
block_ff_dim->intermediate_size- This has always been remapped since LFM2 was added to Transformers in 4.54, but in v5 the old name is nowpoped from the config