Skip to content

[Revert] Remove DeepGEMM availability check in DeepseekV32IndexerMetadataBuilder#38076

Merged
chaunceyjiang merged 1 commit intovllm-project:mainfrom
chaunceyjiang:revert_indexer_cg_support
Mar 26, 2026
Merged

[Revert] Remove DeepGEMM availability check in DeepseekV32IndexerMetadataBuilder#38076
chaunceyjiang merged 1 commit intovllm-project:mainfrom
chaunceyjiang:revert_indexer_cg_support

Conversation

@chaunceyjiang
Copy link
Copy Markdown
Collaborator

@chaunceyjiang chaunceyjiang commented Mar 25, 2026

Purpose

revert #36519

see #37968

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

…dataBuilder

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Copy Markdown
Collaborator Author

/cc @MatthewBonanni PTAL.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the is_deep_gemm_supported import and its corresponding conditional check within the get_cudagraph_support method in vllm/v1/attention/backends/mla/indexer.py. As a result, the method will now always return AttentionCGSupport.UNIFORM_BATCH, simplifying the CUDA graph support logic. There is no feedback to provide as no review comments were made.

Copy link
Copy Markdown
Collaborator

@MatthewBonanni MatthewBonanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaunceyjiang chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2026
@chaunceyjiang chaunceyjiang enabled auto-merge (squash) March 26, 2026 00:15
@chaunceyjiang chaunceyjiang merged commit 87f05d6 into vllm-project:main Mar 26, 2026
60 checks passed
RhizoNymph pushed a commit to RhizoNymph/vllm that referenced this pull request Mar 26, 2026
…dataBuilder (vllm-project#38076)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
HenryTangDev pushed a commit to HenryTangMain/vllm that referenced this pull request Mar 27, 2026
…dataBuilder (vllm-project#38076)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
malaiwah pushed a commit to malaiwah/vllm that referenced this pull request Mar 27, 2026
…dataBuilder (vllm-project#38076)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
…dataBuilder (vllm-project#38076)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc pushed a commit to nithinvc/vllm that referenced this pull request Mar 27, 2026
…dataBuilder (vllm-project#38076)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
…dataBuilder (vllm-project#38076)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Etelis pushed a commit to Etelis/vllm that referenced this pull request Mar 29, 2026
…dataBuilder (vllm-project#38076)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants