[BugFix] Fix order of compile logging#38012
Merged
zou3519 merged 1 commit intovllm-project:mainfrom Mar 24, 2026
Merged
Conversation
Previously the logging went: ``` torch.compile took X s in total Directly load AOT compilation from path ... Initial profiling/warmup run took X s ``` This was a little weird because loading the AOT compilation is a part of "torch.compile". This PR fixes it to ``` Directly load AOT compilation from path ... torch.compile took X s in total Initial profiling/warmup run took X s ``` Signed-off-by: Richard Zou <zou3519@gmail.com>
zou3519
requested review from
BoyuanFeng,
ProExpertProg and
youkaichao
as code owners
Collaborator
Author
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the AOT compilation loading logic. The change correctly moves the counter increment for loaded AOT artifacts and the corresponding log message to be inside the conditional block that checks for the existence of the compiled artifact. This ensures that the metric and log are only updated when an artifact is actually loaded from the cache, fixing a bug where they would be updated even if the cache was missed. While the PR description focuses on logging order, the core of this change is a correctness fix for when the loading log and metric are recorded. The implementation is correct and improves the reliability of compilation metrics and logs.
zhxchen17
approved these changes
Mar 24, 2026
gmagogsfm
approved these changes
Mar 24, 2026
BoyuanFeng
reviewed
Mar 24, 2026
| compilation_counter.num_aot_artifacts_loaded += 1 | ||
| logger.info( | ||
| "Directly load AOT compilation from path %s", aot_compilation_path | ||
| ) |
Collaborator
There was a problem hiding this comment.
nit: why changing indent here?
Collaborator
Author
There was a problem hiding this comment.
the context manager around it prints the "torch.compile takes Xs in total" when it exists
BoyuanFeng
approved these changes
Mar 24, 2026
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com>
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com>
malaiwah
pushed a commit
to malaiwah/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>
bhargav-patel-29
pushed a commit
to Bharatgen-Tech/vllm
that referenced
this pull request
Apr 1, 2026
Signed-off-by: Richard Zou <zou3519@gmail.com> Signed-off-by: bhargav-patel-29 <bhargav.patel@tihiitb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the logging went:
This was a little weird because loading the AOT compilation is a part of "torch.compile".
This PR fixes it to