Make microbatch optimization (DBO) work with general models#37926
Merged
njhill merged 3 commits intovllm-project:mainfrom Mar 24, 2026
Merged
Make microbatch optimization (DBO) work with general models#37926njhill merged 3 commits intovllm-project:mainfrom
njhill merged 3 commits intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully extends microbatch optimization to general models by removing the dependency on a model attribute and handling optional input_ids and inputs_embeds. The changes are logical and well-aligned with the goal. I have one suggestion to improve consistency and prevent a potential runtime error, which is detailed in my comment.
1 task
LucasWilkinson
approved these changes
Mar 23, 2026
|
Hi @0xjunhao, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Junhao Li <junhao@ubicloud.com>
Contributor
Author
|
Seems this is the only error and it's unrelated to this PR. |
SageMoore
approved these changes
Mar 24, 2026
Contributor
SageMoore
left a comment
There was a problem hiding this comment.
Looks reasonable. Thanks for the contribution!
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com>
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Mar 27, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com>
malaiwah
pushed a commit
to malaiwah/vllm
that referenced
this pull request
Mar 27, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com> Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…ject#37926) Signed-off-by: Junhao Li <junhao@ubicloud.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, microbatch optimization only works for text models, and the model must expose an internal
modelattribute (e.g.vllm/vllm/model_executor/models/deepseek_v2.py
Lines 1339 to 1341 in 5bf3c42
Otherwise, vLLM fails to start. This PR extends microbatch optimization to general models, removing the requirement for text-only models and the need for an internal
modelattribute.Test Plan
vllm serve Qwen/Qwen3.5-35B-A3B --trust-remote-code --gpu-memory-utilization 0.8 -dp 2 --enable-expert-parallel --all2all-backend deepep_low_latency --enable-dbo
Test Result
Before the fix:
For multimodal models, it gives the following error:
#34210
For models without an internal
modelattribute, it gives the following error:After the fix
The server starts and runs successfully.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.