[MRV2] Skip hidden states allocation for PW CUDA graphs#37818
Merged
WoosukKwon merged 1 commit intomainfrom Mar 22, 2026
Merged
[MRV2] Skip hidden states allocation for PW CUDA graphs#37818WoosukKwon merged 1 commit intomainfrom
WoosukKwon merged 1 commit intomainfrom
Conversation
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an optimization to avoid allocating memory for hidden states when capturing piecewise (PW) CUDA graphs. The changes involve adding a condition to bypass hidden state handling for CUDAGraphMode.PIECEWISE during graph capture and adding a clarifying comment. The implementation appears correct and effectively reduces memory usage for PW graphs without affecting the functionality of full CUDA graphs.
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Mar 23, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Mar 27, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…#37818) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.