Skip to content

[Bugfix] Handle libsndfile sf_error(NULL) race condition in audio fallback #37782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Isotr0py merged 2 commits into from
Mar 22, 2026
Merged

[Bugfix] Handle libsndfile sf_error(NULL) race condition in audio fallback #37782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4016079
[Bugfix] Handle libsndfile sf_error(NULL) race condition in audio fal…
AndreasKaratzas Mar 22, 2026
e4137e0
Merge remote-tracking branch 'origin/main' into akaratza_fix_entrypoi…
AndreasKaratzas Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vllm/multimodal/media/audio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,14 @@
# Public libsndfile error codes exposed via `soundfile.LibsndfileError.code`, soundfile
# being librosa's main backend. Used to validate if an audio loading error is due to a
# server error vs a client error (invalid audio file).
# 0 = sf_error(NULL) race condition: when multiple threads fail sf_open_virtual
# concurrently, one thread may clear the global error before another reads it,
# producing code=0 ("Garbled error message from libsndfile" in soundfile).
# See: https://github.com/bastibe/python-soundfile/issues/479
# 1 = unrecognised format (file is not a supported audio container)
# 3 = malformed file (corrupt or structurally invalid audio)
# 4 = unsupported encoding (codec not supported by this libsndfile build)
_BAD_SF_CODES = {1, 3, 4}
_BAD_SF_CODES = {0, 1, 3, 4}
Comment thread
AndreasKaratzas marked this conversation as resolved.


def load_audio_pyav(
Expand Down
Loading