[ROCm][CI] get_cu_count was renamed to num_compute_units in #35042#37764
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 22, 2026
Merged
[ROCm][CI] get_cu_count was renamed to num_compute_units in #35042#37764DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
…ect#35042 Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
added
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates monkeypatch calls in tests/model_executor/layers/test_rocm_unquantized_gemm.py. The function get_cu_count was renamed to num_compute_units, and these changes update the test mocks to use the new function name. The modifications are confined to the test file and align with the goal of fixing continuous integration failures.
jikunshang
approved these changes
Mar 22, 2026
DarkLight1337
approved these changes
Mar 22, 2026
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Mar 23, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Mar 27, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…ect#35042 (vllm-project#37764) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_rocm_unquantized_gemm.pyintroduced in [ROCm] Enable wvSplitK skinny GEMM kernel for RDNA4/gfx1x decode #34709get_cu_countwas renamed tonum_compute_unitsin [Platform] Add current_platform.num_compute_units interface #35042, but the test PR was authored against the old namecc @kenroche