Fix various config related issues for Transformers v5#37681
Merged
DarkLight1337 merged 7 commits intovllm-project:mainfrom Mar 20, 2026
Merged
Fix various config related issues for Transformers v5#37681DarkLight1337 merged 7 commits intovllm-project:mainfrom
DarkLight1337 merged 7 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
DarkLight1337,
NickLucche,
aarnphm,
patrickvonplaten and
robertgshaw2-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a series of fixes to address configuration-related issues, primarily for compatibility with Transformers v5. The changes span multiple configuration classes, including ColPaliConfig, Qwen3ASRConfig, DeepseekVLV2Config, ParakeetConfig, and SpeculatorsConfig, to correct initialization logic, argument ordering, and handling of optional parameters. The modifications appear to correctly resolve the described issues, and I have no further comments.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
DarkLight1337
approved these changes
Mar 20, 2026
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
…7681) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…7681) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…7681) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
…7681) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…7681) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
7 tasks
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…7681) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColPaliConfig-projection_dimis a field ofPaliGemmaConfigand cannot beNoneQwen3ASRConfig-thinker_configneeds to be set beforesuper().__init__is calledkimi_k2function calling test - settingkv_lora_rank=Nonecaused attribute errors for theQwen3Configparams.jsoncan explicitly setmax_source_positions: nullbutNoneis not a valid value for this field inWhisperConfigSpeculatorsConfig-PretrainedConfig.__init__is not expected to be passed all the config fields. It is safest to set any that it is not expecting beforehandDeepSeekVL2andParakeet