Skip to content

[ROCm][CI] Fix flaky Cohere/OpenAI embedding parity test #37616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noooop merged 4 commits into from
Mar 25, 2026
Merged

[ROCm][CI] Fix flaky Cohere/OpenAI embedding parity test #37616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de7d9d7
[ROCm][CI] Fix flaky Cohere/OpenAI embedding parity test
AndreasKaratzas Mar 19, 2026
21ad38c
[ROCm][CI] Fix flaky Cohere/OpenAI embedding parity test
AndreasKaratzas Mar 20, 2026
24835c8
Merge remote-tracking branch 'origin/main' into akaratza_fixcohere_op…
AndreasKaratzas Mar 25, 2026
3b81963
Validate pooling params early to avoid async generator exception prop…
AndreasKaratzas Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/entrypoints/pooling/embed/test_cohere_openai_parity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import pytest
import requests

from tests.utils import RemoteOpenAIServer
from tests.utils import ROCM_EXTRA_ARGS, RemoteOpenAIServer

MODEL_NAME = "BAAI/bge-base-en-v1.5"
DTYPE = "bfloat16"
Expand All @@ -28,7 +28,7 @@ def server():
"512",
"--gpu-memory-utilization",
"0.02",
]
] + ROCM_EXTRA_ARGS
with RemoteOpenAIServer(MODEL_NAME, args) as remote_server:
yield remote_server

Expand Down
4 changes: 2 additions & 2 deletions tests/entrypoints/pooling/embed/test_online_dimensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from tests.conftest import HfRunner
from tests.models.language.pooling.embed_utils import run_embedding_correctness_test
from tests.models.utils import EmbedModelInfo
from tests.utils import RemoteOpenAIServer
from tests.utils import ROCM_EXTRA_ARGS, RemoteOpenAIServer
from vllm.entrypoints.pooling.embed.protocol import EmbeddingResponse
from vllm.platforms import current_platform

Expand Down Expand Up @@ -49,7 +49,7 @@ def server(model_info, dtype: str):
"--enforce-eager",
"--max-model-len",
"512",
]
] + ROCM_EXTRA_ARGS

if model_info.name == "Snowflake/snowflake-arctic-embed-m-v1.5":
# Manually enable Matryoshka Embeddings
Expand Down
1 change: 1 addition & 0 deletions vllm/entrypoints/pooling/base/serving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ async def _prepare_generators(
)

pooling_params = self.io_processor.create_pooling_params(ctx.request)
pooling_params.verify(self.model_config)

for i, engine_prompt in enumerate(ctx.engine_prompts):
prompt_request_id = (
Expand Down
3 changes: 3 additions & 0 deletions vllm/entrypoints/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,9 @@ def create_error_response(

if isinstance(message, Exception):
exc = message
logger.debug(
"create_error_response called with %s: %s", type(exc).__name__, exc
)

from vllm.exceptions import VLLMNotFoundError, VLLMValidationError

Expand Down
Loading