Skip to content

[V0 Deprecation] Deprecate --disable-frontend-multiprocessing#37612

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
sfeng33:depreciate-v0
Mar 20, 2026
Merged

[V0 Deprecation] Deprecate --disable-frontend-multiprocessing#37612
DarkLight1337 merged 1 commit intovllm-project:mainfrom
sfeng33:depreciate-v0

Conversation

@sfeng33
Copy link
Contributor

@sfeng33 sfeng33 commented Mar 19, 2026

Purpose

  • Remove the --disable-frontend-multiprocessing CLI flag from BaseFrontendArgs, API server, and benchmarks
  • Clean up test parametrizations that varied over this flag, reducing redundant test variants

Test Plan

pytest tests/distributed/test_pipeline_parallel.py -v -s
pytest tests/entrypoints/instrumentator/test_basic.py -v -s
pytest tests/entrypoints/instrumentator/test_metrics.py -v -s
pytest tests/entrypoints/openai/completion/test_completion_with_prompt_embeds.py -v -s
pytest tests/entrypoints/openai/completion/test_shutdown.py -v -s
pytest tests/v1/entrypoints/openai/test_completion.py -v -s

Signed-off-by: sfeng33 <4florafeng@gmail.com>
@mergify mergify bot added frontend performance Performance-related issues v1 labels Mar 19, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the deprecated --disable-frontend-multiprocessing CLI flag. The changes are applied consistently across the codebase, including benchmarks, API servers, and tests. The removal simplifies the configuration and test setup, which is a positive improvement. The code changes are correct and align with the goal of deprecating the V0 flag.

@sfeng33 sfeng33 marked this pull request as ready for review March 19, 2026 23:27
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2026
@DarkLight1337 DarkLight1337 merged commit 9040151 into vllm-project:main Mar 20, 2026
56 checks passed
@sfeng33 sfeng33 deleted the depreciate-v0 branch March 20, 2026 03:32
chooper26 pushed a commit to intellistream/vllm-hust that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants