[Refactor] Move serve entrypoint tests under tests/entrypoints/serve/#37595
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 20, 2026
Merged
[Refactor] Move serve entrypoint tests under tests/entrypoints/serve/#37595DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
|
This pull request has merge conflicts that must be resolved before it can be |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully refactors the test directory structure by moving tests/entrypoints/instrumentator/ to tests/entrypoints/serve/instrumentator/ and tests/entrypoints/openai/cpu/ to tests/entrypoints/serve/render/. The changes in the .buildkite configuration files and the Python test files correctly reflect these new paths and updated import statements. The refactoring appears to be well-executed and does not introduce any new issues or bugs.
sfeng33
requested review from
DarkLight1337,
NickLucche,
aarnphm and
robertgshaw2-redhat
as code owners
DarkLight1337
approved these changes
Mar 20, 2026
Member
|
Please fix merge conflicts |
Signed-off-by: sfeng33 <4florafeng@gmail.com>
github-actions
bot
added
the
ready
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
…vllm-project#37595) Signed-off-by: sfeng33 <4florafeng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
tests/entrypoints/instrumentator/→tests/entrypoints/serve/instrumentator/tests/entrypoints/openai/cpu/→tests/entrypoints/serve/render/