[Refactor] Relocate entrypoint tests to match serving code structure#37593
Merged
DarkLight1337 merged 4 commits intovllm-project:mainfrom Mar 20, 2026
Merged
[Refactor] Relocate entrypoint tests to match serving code structure#37593DarkLight1337 merged 4 commits intovllm-project:mainfrom
DarkLight1337 merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: sfeng33 <4florafeng@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the test suite by reorganizing entrypoint tests to mirror the serving code structure. The changes primarily involve moving test files and updating import paths. My review identified a couple of areas for improvement. Firstly, a test that was previously ignored in the AMD CI test suite might now be executed due to the refactoring, potentially causing CI failures. Secondly, there's an inconsistent use of relative imports in one of the updated test files, while others were correctly switched to absolute imports. Addressing these points will improve CI stability and code consistency.
Signed-off-by: sfeng33 <4florafeng@gmail.com>
sfeng33
requested review from
DarkLight1337,
NickLucche,
aarnphm,
robertgshaw2-redhat and
ywang96
as code owners
DarkLight1337
approved these changes
Mar 20, 2026
github-actions
bot
added
the
ready
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
…llm-project#37593) Signed-off-by: sfeng33 <4florafeng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Reorganize entrypoint tests into directories that mirror the serving code structure, improving discoverability and maintainability.
tests/entrypoints/openai/test_protocol.pytests/entrypoints/openai/responses/test_protocol.pytests/entrypoints/test_responses_utils.pytests/entrypoints/openai/responses/test_responses_utils.pytests/entrypoints/openai/test_serving_tokens.pytests/entrypoints/serve/disagg/test_serving_tokens.pytests/entrypoints/openai/test_lora_adapters.pytests/entrypoints/serve/lora/test_lora_adapters.pytests/entrypoints/openai/test_serving_models.pytests/entrypoints/serve/lora/test_serving_models.pytests/entrypoints/openai/test_launch_render.pytests/entrypoints/serve/render/test_launch_render.pytests/entrypoints/openai/test_embedding_shape_validation.pytests/multimodal/test_embedding_shape_validation.py