[CI] Removing deprecated rlhf examples reference#37585
Merged
tjtanaa merged 3 commits intovllm-project:mainfrom Mar 20, 2026
Merged
[CI] Removing deprecated rlhf examples reference#37585tjtanaa merged 3 commits intovllm-project:mainfrom
tjtanaa merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
3 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully removes deprecated references to rlhf.py and rlhf_colocate.py examples, updating paths to the new examples/rl/ directory. This aligns with the stated objective of cleaning up forgotten spots after repositioning the Distributed test group. The changes are straightforward and appear to be a correct cleanup without introducing any new issues.
robertgshaw2-redhat
approved these changes
Mar 19, 2026
|
This pull request has merge conflicts that must be resolved before it can be |
…ted_rlhf Signed-off-by: Andreas Karatzas <akaratza@amd.com>
auto-merge was automatically disabled
March 19, 2026 19:37
Head branch was pushed to by a user without write access
github-actions
bot
added
the
ready
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some forgotten spots after the repositioning of Distributed test group. This PR attempts to complement the following:
rlhf_async_new_apis.py#37532cc @kenroche